More on sympy #890
Draft
More on sympy #890
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mmatera
commented
Jul 24, 2023
| @@ -49,6 +49,8 @@ | |||
| RealOne = Real(1.0) | |||
|
|
|||
|
|
|||
| use_sympy_for_arithmetic = False | |||
There was a problem hiding this comment.
Setting this variable to True we use a eval_Times and eval_Plus implementation based on sympy. Notice that it fails to pass several tests.
mmatera
commented
Jul 24, 2023
test/core/test_serialization.py
Outdated
| from mathics.session import MathicsSession | ||
|
|
||
| import_and_load_builtins() |
There was a problem hiding this comment.
I had to add this line on each test that I want to run individually. Maybe it should be added in mathics.session.
mmatera
commented
Jul 24, 2023
| @@ -402,18 +401,6 @@ def __new__(cls, name: str, sympy_dummy=None): | |||
| # For example, this can happen with String constants. | |||
|
|
|||
| self.hash = hash((cls, name)) | |||
|
|
|||
There was a problem hiding this comment.
Dummy symbols are something related to sympy and not with the basic Mathics data structures. It is not needed anymore.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@rocky, this PR completes #888 by rewriting
from_sympyin the form of a dispatch table instead of a very longif/elifroutine. Also, I tried to implement a way to avoid the conversions back-and-forth.Finally, I included some code to implement
eval_Plusandeval_Timesfully based on Sympy.